Alon Bar-Lev has posted comments on this change.

Change subject: engine, webadmin: Webadmin read reports.xml from remote reports 
app
......................................................................


Patch Set 15:

I thought about this again, and see no reason to disable ssl host verification 
nor trust check.

1. use the /etc/pki/ovirt-engine/.truststore as strust store, do not skip trust 
check.

2. use host name verification unless host is 'localhost'.

the recommendation of using single servlet still applies, most probably should 
go into uutils, as it is a generic delegation servlet, delegation == transmit 
same headers, same body. please confirm that destination servlet should not 
create j2ee session.

I would have preferred to use /etc/ovirt-enigne/engine.conf.d to store 
configuration and not database, this will enable %{XXXX} to be specify in init 
parameter as we do in other cases, so no need for Config class usage.

-- 
To view, visit http://gerrit.ovirt.org/29723
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to