Martin Peřina has posted comments on this change. Change subject: core: Add config value to enable to skip fencing if SD is active ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/30193/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1875: /** Line 1876: * Feature to skip fencing if host is connected to at least one storage domain Line 1877: */ Line 1878: @TypeConverterAttribute(Boolean.class) Line 1879: @DefaultValueAttribute("false") > IMO this should be defaulted to "true" since it is set for all version belo Done Line 1880: SkipFencingIfSDActiveSupported, Line 1881: Line 1882: Invalid http://gerrit.ovirt.org/#/c/30193/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 793: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.1'); Line 794: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.2'); Line 795: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.3'); Line 796: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'false', '3.4'); Line 797: select fn_db_add_config_value('SkipFencingIfSDActiveSupported', 'true', '3.5'); > This line is not needed , if version value not found then it is taken from Done Line 798: Line 799: ------------------------------------------------------------------------------------ Line 800: -- Update with override section Line 801: ------------------------------------------------------------------------------------ -- To view, visit http://gerrit.ovirt.org/30193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9f1e480a5cedb7988eba37701c3db7b3950c010 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
