Yair Zaslavsky has posted comments on this change. Change subject: engine : Command Executor should persist command before submitting to threadpool ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/29219/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 84: case NOT_STARTED: Line 85: coco.retrieveCommand(cmdEntity.getId()).setCommandStatus(CommandStatus.FAILED_RESTARTED); Line 86: break; Line 87: default: Line 88: if (!cmdEntity.isCallBackNotified()) { why do you differentiate here for other statuses, and not fail the command regardless of the status? ok, well, maybe the only status not to fail if it has already failed or completed? Line 89: addToCallBackMap(cmdEntity); Line 90: } Line 91: break; Line 92: } Line 121: return executeCommand(command, cmdContext); Line 122: } Line 123: }); Line 124: } catch(RejectedExecutionException ex) { Line 125: command.setCommandStatus(CommandStatus.FAILED); I think we should consider perform audit log or any other log with anti flood protection to indicate we have reached this situation. If we're failing commands due to Reject of thread pool, the ovirt administrator should know his system is extermely busy. Line 126: } Line 127: return command.getCommandId(); Line 128: } Line 129: -- To view, visit http://gerrit.ovirt.org/29219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
