Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: fix available locale variable ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/30324/4/frontend/webadmin/modules/pom.xml File frontend/webadmin/modules/pom.xml: Line 66: <!-- GWT CSS obfuscation style. production should be 'obf', use 'pretty' in development for easier css debugging --> Line 67: <gwt.cssResourceStyle>obf</gwt.cssResourceStyle> Line 68: <!-- I need relative paths here, due to unknown file system, so I need to construct the path from the base dir + this path. Line 69: the base dir is too far into the tree, so I need to back out a bit --> Line 70: <allLocaleFile>../../../../backend/manager/modules/utils/src/main/resources/languages.properties</allLocaleFile> won't it better to use something like: ${project.parent.parent.basedir}/... Line 71: </properties> Line 72: <dependencyManagement> Line 73: <dependencies> Line 74: <!-- Exclude Guice dependencies from GIN --> http://gerrit.ovirt.org/#/c/30324/4/frontend/webadmin/modules/webadmin/pom.xml File frontend/webadmin/modules/webadmin/pom.xml: Line 173: </property> Line 174: </properties> Line 175: </configuration> Line 176: </execution> Line 177: </executions> won't it better to do this at Makefile? have default of only us-en, and provide production list as -Dxxx="ccc,sss,aaa" at make level? alternative is to put this in frontend so it common to both webadmin/userportal without repeat? Line 178: </plugin> Line 179: <plugin> Line 180: <groupId>org.apache.maven.plugins</groupId> Line 181: <artifactId>maven-war-plugin</artifactId> -- To view, visit http://gerrit.ovirt.org/30324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc90fdcd05dd460cce4b2084a8e5793b77b5b09b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
