Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Fixing missing name field for admin user
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

I was sure I +1-ed this

http://gerrit.ovirt.org/#/c/30488/2/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java
File 
backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/internal/InternalAuthz.java:

Line 120:                         Authz.PrincipalRecord.NAME,
Line 121:                         userName
Line 122:                 ).mput(
Line 123:                         Authz.PrincipalRecord.FIRST_NAME,
Line 124:                         userName
I would have called getProperty twice... not that it is important.
Line 125:                 ).mput(
Line 126:                         Authz.PrincipalRecord.ID,
Line 127:                         
configuration.getProperty("config.authz.user.id")
Line 128:                 );


-- 
To view, visit http://gerrit.ovirt.org/30488
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4ae5e103ecc9f85fbeaef6c9bc3351e9d4beb21
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to