Moti Asayag has posted comments on this change. Change subject: engine: External network with vlan must be labeled ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/30005/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java: Line 131: } Line 132: Line 133: public ValidationResult externalNetworkVlanValid() { Line 134: return ValidationResult.failWith(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_NETWORK_WITH_VLAN_MUST_BE_LABELED) Line 135: .when(network.getVlanId() != null && network.getLabel() == null); > I would check that the label is not empty as well.. at this point the label should contain a valid value or be null since it is being validated by the hibernate validation. Line 136: } Line 137: Line 138: @Override Line 139: protected DbFacade getDbFacade() { -- To view, visit http://gerrit.ovirt.org/30005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811a0d55798b7dd78d37880055c4ac00303b679f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
