Martin Mucha has posted comments on this change. Change subject: core: added user permissions to macPools ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/29846/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 319: public List<PermissionSubject> getPermissionCheckSubjects() { Line 320: final List<PermissionSubject> result = new ArrayList<>(super.getPermissionCheckSubjects()); Line 321: Line 322: final Guid macPoolId = getParameters().getStoragePool() == null ? null : getParameters().getStoragePool().getMacPoolId(); Line 323: final boolean changingPoolDefinition = macPoolId != null && macPoolId.equals(getOldMacPoolId()); > i guess you meant to negate the second part of the condition: Done Line 324: if (changingPoolDefinition) { Line 325: result.add(new PermissionSubject(macPoolId, VdcObjectType.MacPool, ActionGroup.CONFIGURE_MAC_POOL)); Line 326: } Line 327: -- To view, visit http://gerrit.ovirt.org/29846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d080b6628f86ab2ff88f8e2dfaab21d367c7f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
