anmolbabu has posted comments on this change. Change subject: webadmin : sort status and cluster column under volumes ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/30192/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusCell.java: Line 27: protected ImageResource upImage = resources.upImage(); Line 28: protected ImageResource allBricksDownImage = resources.volumeAllBricksDownWarning(); Line 29: protected ImageResource volumeSomeBricksDownImage = resources.volumeBricksDownWarning(); Line 30: Line 31: protected enum VOLUMESTATUS { > VolumeStatus Done Line 32: UP, Line 33: DOWN, Line 34: ALLBRICKSDOWN, Line 35: SOMEBRICKSDOWN; Line 30: Line 31: protected enum VOLUMESTATUS { Line 32: UP, Line 33: DOWN, Line 34: ALLBRICKSDOWN, > ALL_BRICKS_DOWN Done Line 35: SOMEBRICKSDOWN; Line 36: }; Line 37: Line 38: protected VOLUMESTATUS getVolumeStatus(GlusterVolumeEntity volume) { http://gerrit.ovirt.org/#/c/30192/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeStatusColumn.java: Line 35: private final CustomStatusImageComaparator imageComparator = new CustomStatusImageComaparator(imageWeightMap); Line 36: Line 37: @Override Line 38: public int compare(GlusterVolumeEntity o1, GlusterVolumeEntity o2) { Line 39: return imageComparator.compare(statusCell.getStatusImage(statusCell.getVolumeStatus(o1)), statusCell.getStatusImage(statusCell.getVolumeStatus(o2))); > Are we recalculating the volume status here? Yes, statusCell.getVolumeStatus(o1) in statusCell.getStatusImage(statusCell.getVolumeStatus(o1)) and statusCell.getStatusImage(statusCell.getVolumeStatus(o2)) To get image we are calculating the status Line 40: } Line 41: }); Line 42: } Line 43: -- To view, visit http://gerrit.ovirt.org/30192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73036f5a5d8e14df2bebdaeb2b3fa95938db2e8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
