anmolbabu has posted comments on this change. Change subject: gluster: show warning in rebalance and remove brick ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/30199/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 363: model.setHashName("rebalance_volume"); //$NON-NLS-1$ Line 364: model.setMessage(ConstantsManager.getInstance().getConstants().rebalanceVolumesMessage()); Line 365: if (getSelectedItems() == null) { Line 366: return; Line 367: } can you please do this before even creating the ConfirmationModel.Bcoz, otherwise, the confirmation model is created and it is set as the window w/o even close command.and to remove it I guess browser tab refresh is the only way out Line 368: Line 369: ArrayList<String> list = new ArrayList<String>(); Line 370: for (GlusterVolumeEntity item : Linq.<GlusterVolumeEntity> cast(getSelectedItems())) Line 371: { http://gerrit.ovirt.org/#/c/30199/1/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 1 Line 2 Line 3 Can you please undo this -- To view, visit http://gerrit.ovirt.org/30199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cbf4043c848a26bdbc2a796ebe79f5af87b31f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
