Martin Mucha has posted comments on this change. Change subject: core: MacPoolManager-->ScopedMacPoolManager ......................................................................
Patch Set 45: (1 comment) http://gerrit.ovirt.org/#/c/26800/45/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java: Line 259: logable.addCustomValue("IfaceName", iface.getName()); Line 260: return logable; Line 261: } Line 262: Line 263: public VmInterfaceManager setMacPool(MacPoolManagerStrategy macPool) { > So just call the constructor with MacPool where needed, and the default whe well, technically this is just a different way to write this, but exactly as problematic. Instead of knowing what to set, there's necessity to know which constructor to use. This is technically the same, except for fact, that constructor scale worse upon future code modifications, goes against DI approach. So constructor approach is probably worse(yes, saves some letters). DONE. Line 264: this.macPool = macPool; Line 265: return this; Line 266: } -- To view, visit http://gerrit.ovirt.org/26800 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I779f4d031409fbc422077ddf291fa34f955f3206 Gerrit-PatchSet: 45 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
