Alon Bar-Lev has posted comments on this change. Change subject: aaa: reactivate user ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29974/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java: Line 38: @Override Line 39: protected void executeCommand() { Line 40: DbUser userToAdd = getParameters().getUserToAdd(); Line 41: for (DbUser user : SyncUsers.sync(Arrays.asList(userToAdd))) { Line 42: DbFacade.getInstance().getDbUserDao().saveOrUpdate(user); we have one user... no need to loop... if it is a new user - save only if active if it is existing user - update always Line 43: } Line 44: setActionReturnValue(DbFacade.getInstance().getDbUserDao().getByExternalId(userToAdd.getDomain(), userToAdd.getExternalId()).getId()); Line 45: setSucceeded(true); Line 46: } -- To view, visit http://gerrit.ovirt.org/29974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556d8da48a858ce193865e84fb6c7cb4043a8e5b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
