Vered Volansky has posted comments on this change. Change subject: core: Added VM memory validation on snapshot ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/30040/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 144: Line 145: return toReturn; Line 146: } Line 147: Line 148: private boolean validateStorageDomains(List<DiskImage> newDisksList) { Moved around the code, only new thing is other storage validation for cloned disks. Line 149: List<DiskImage> cloneDisksList = getMemoryImageBuilder().getDisksToBeCreated(); Line 150: List<DiskImage> disksList = getAllDisks(newDisksList, cloneDisksList); Line 151: MultipleStorageDomainsValidator sdValidator = createMultipleStorageDomainsValidator(disksList); Line 152: return validate(sdValidator.allDomainsExistAndActive()) http://gerrit.ovirt.org/#/c/30040/5/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommandTest.java: Line 299: doReturn(ValidationResult.VALID).when(diskImagesValidator).diskImagesNotLocked(); Line 300: doReturn(ValidationResult.VALID).when(diskImagesValidator).diskImagesNotIllegal(); Line 301: doReturn(ValidationResult.VALID).when(multipleStorageDomainsValidator).allDomainsExistAndActive(); Line 302: doReturn(ValidationResult.VALID).when(multipleStorageDomainsValidator).allDomainsWithinThresholds(); Line 303: doReturn(ValidationResult.VALID).when(multipleStorageDomainsValidator).allDomainsHaveSpaceForAllDisks(anyList(), anyList()); has to be anyList. This is what jenkins complained about before. Line 304: } Line 305: Line 306: private void setUpGeneralValidations() { Line 307: doReturn(Boolean.TRUE).when(cmd).validateVM(vmValidator); -- To view, visit http://gerrit.ovirt.org/30040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fc127147bdea8737fecb034c88079521b8a8bd6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
