Daniel Erez has posted comments on this change. Change subject: core: Use audit log only when failed to use retrieve command. ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/30061/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 214: OvfUtils.getOvfEntities((byte[]) retrievedByteData.getReturnValue(), Line 215: getParameters().getStorageDomainId()); Line 216: } else { Line 217: log.errorFormat("Image data could not be retrieved for disk id {0} in storage domain id {1}", Line 218: ovfDisk.getId()); missing domain id Line 219: AuditLogDirector.log(this, AuditLogType.RETRIEVE_OVF_STORE_FAILED); Line 220: } Line 221: } catch (RuntimeException e) { Line 222: // We are catching RuntimeException, since the call for OvfUtils.getOvfEntities will throw Line 224: log.errorFormat("Image data could not be retrieved for disk id {0} in storage domain id {1}. Error: {2}", Line 225: ovfDisk.getId(), Line 226: getParameters().getStorageDomainId(), Line 227: e); Line 228: AuditLogDirector.log(this, AuditLogType.RETRIEVE_OVF_STORE_FAILED); shouldn't be an error auditlog in this case? Line 229: } Line 230: } Line 231: } else { Line 232: log.warnFormat("There are no OVF_STORE disks on storage domain id {0}", Line 229: } Line 230: } Line 231: } else { Line 232: log.warnFormat("There are no OVF_STORE disks on storage domain id {0}", Line 233: getParameters().getStorageDomainId()); shouldn't be a warning AuditLog as well? Line 234: } Line 235: return ovfEntitiesFromTar; Line 236: } Line 237: -- To view, visit http://gerrit.ovirt.org/30061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1eb5a687429c081f42bdc63bf3b8dd17eb295236 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
