Alexander Wels has posted comments on this change. Change subject: webadmin: Keep validation/event message if there is an iso update to ovirt node host ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/29897/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 1897: private void updateAlerts() { Line 1898: final VDS vds = (VDS) getSelectedItem(); Line 1899: final UIConstants constants = ConstantsManager.getInstance().getConstants(); Line 1900: if (vds.getVdsType() == VDSType.oVirtNode) Line 1901: { Can you move the { up to the previous line to comply with coding standards? Line 1902: AsyncDataProvider.getInstance().getoVirtISOsList(new AsyncQuery(this, Line 1903: new INewAsyncCallback() { Line 1904: @Override Line 1905: public void onSuccess(Object target, Object returnValue) { Line 1905: public void onSuccess(Object target, Object returnValue) { Line 1906: Line 1907: ArrayList<RpmVersion> isos = (ArrayList<RpmVersion>) returnValue; Line 1908: if (isos.size() > 0) Line 1909: { Can you move the { up to the previous line to comply with coding standards? Line 1910: String [] hostOsInfo = vds.getHostOs().split("-"); //$NON-NLS-1$ //$NON-NLS-2$ Line 1911: for (int counter = 0; counter < hostOsInfo.length; counter++) { Line 1912: hostOsInfo[counter] = hostOsInfo[counter].trim(); Line 1913: } Line 1923: && vds.getStatus() != VDSStatus.Reboot Line 1924: && vds.getStatus() != VDSStatus.PendingApproval; Line 1925: Line 1926: if (!executionAllowed) Line 1927: { Can you move the { up to the previous line to comply with coding standards? Line 1928: getUpgradeCommand() Line 1929: .getExecuteProhibitionReasons() Line 1930: .add(constants Line 1931: .switchToMaintenanceModeToEnableUpgradeReason()); -- To view, visit http://gerrit.ovirt.org/29897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b58f3c5f2ce1a7e9f5c151c07c6c32a2cbb8fe1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
