Martin Peřina has posted comments on this change. Change subject: kdump: Fix kexec-tools detection in node ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/29283/6/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 115: # on node check ovirt-node-plugin-vdsm version Line 116: plugin_version = self.environment[ Line 117: odeploycons.VdsmEnv.NODE_PLUGIN_VERSION Line 118: ] Line 119: if ( > result = expression? Done Line 120: plugin_version is not None and Line 121: compareEVR( Line 122: (None, plugin_version[0], plugin_version[1]), Line 123: (None, '0.2.0', None) Line 123: (None, '0.2.0', None) Line 124: ) >= 0 Line 125: ): Line 126: result = True Line 127: > please drop the space Done Line 128: else: Line 129: # on standard host use packager Line 130: min_version = self._get_min_kexec_tools_version() Line 131: if min_version is not None: -- To view, visit http://gerrit.ovirt.org/29283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I136469c35e7fc11d3eb89ab5b4fc71395010f42b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
