Martin Peřina has posted comments on this change. Change subject: packaging: Don't show fence_kdump listener in summary ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29896/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py: Line 49: ) Line 50: def _late_setup_service_state(self): Line 51: self._needStart = self.services.status( Line 52: name=oenginecons.Const.FENCE_KDUMP_LISTENER_SERVICE_NAME, Line 53: ) > Ok, so you can remove this method and just rely on self._enabled as a condi Well, what about upgrade 3.5 -> 3.6? If we would like to change default config for fence_kdump listener in 3.6, then we need to stop running service, update config and start it when setup finished. Isn't this method required to achieve this? Line 54: Line 55: @plugin.event( Line 56: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 57: before=( -- To view, visit http://gerrit.ovirt.org/29896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib31f1ff25ef406ccdf40e7ddcb4047984fef3ebd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
