Sandro Bonazzola has posted comments on this change. Change subject: added EngineStarting state ......................................................................
Patch Set 2: (2 comments) Code looks good to me, just some typo around. http://gerrit.ovirt.org/#/c/30025/2//COMMIT_MSG Commit Message: Line 6: Line 7: added EngineStarting state Line 8: Line 9: when then VM with engine is starting it takes some time and goes Line 10: thru states "waitforlunch" and "powering up". During the start up I guess it should be launch, not lunch... thru -> through Line 11: the engine was marked as UnexpectedlyDown because it wasn't 'up' Line 12: and the host got score 0 which might lead to killing the VM while Line 13: it's starting and trying to start it on another host where the Line 14: same situation repeats. http://gerrit.ovirt.org/#/c/30025/2/ovirt_hosted_engine_ha/lib/engine.py File ovirt_hosted_engine_ha/lib/engine.py: Line 1: # Line 2: # ovirt-hosted-engine-ha -- ovirt hosted engine high availability Line 3: # Copyright (C) 2013 Red Hat, Inc. 2014 Line 4: # Line 5: # This library is free software; you can redistribute it and/or Line 6: # modify it under the terms of the GNU Lesser General Public Line 7: # License as published by the Free Software Foundation; either -- To view, visit http://gerrit.ovirt.org/30025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7e5bb28eeb839b684be74ea768265d9dab01175 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches