Oved Ourfali has posted comments on this change. Change subject: core: add host_provider_id to vdsStatic ......................................................................
Patch Set 2: (5 comments) Also, when verifying make sure you run the DB tests. http://gerrit.ovirt.org/#/c/30059/2/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 1324: <value>b5:ad:16:19:06:9f:b3:41:69:eb:1c:42:1d:12:b5:31</value> Line 1325: <value>22</value> Line 1326: <value>root</value> Line 1327: <value>1</value> Line 1328: <value>0</value> shouldn't it be a guid value? Or null. Line 1329: <value>0</value> Line 1330: </row> Line 1331: <row> Line 1332: <value>afce7a39-8e8c-4819-ba9c-796d316592e7</value> Line 1360: <value>22</value> Line 1361: <value>root</value> Line 1362: <value>1</value> Line 1363: <value>1</value> Line 1364: <value>0</value> shouldn't it be a guid value? Or null. Line 1365: </row> Line 1366: <row> Line 1367: <value>afce7a39-8e8c-4819-ba9c-796d316592e8</value> Line 1368: <value>localfs-vds</value> Line 1395: <value>22</value> Line 1396: <value>root</value> Line 1397: <value>1</value> Line 1398: <value>2</value> Line 1399: <value>0</value> shouldn't it be a guid value? Or null. Line 1400: </row> Line 1401: <row> Line 1402: <value>23f6d691-5dfb-472b-86dc-9e1d2d3c18f3</value> Line 1403: <value>gluster-server1</value> Line 1429: <value>b5:ad:16:19:06:9f:b3:41:69:eb:1c:42:1d:12:b5:31</value> Line 1430: <value>22</value> Line 1431: <value>root</value> Line 1432: <value>1</value> Line 1433: <value>0</value> shouldn't it be a guid value? Or null. Line 1434: <value>0</value> Line 1435: </row> Line 1436: <row> Line 1437: <value>2001751e-549b-4e7a-aff6-32d36856c125</value> Line 1465: <value>22</value> Line 1466: <value>root</value> Line 1467: <value>1</value> Line 1468: <value>1</value> Line 1469: <value>0</value> shouldn't it be a guid value? Or null. Line 1470: </row> Line 1471: </table> Line 1472: Line 1473: <table name="vm_ovf_generations"> -- To view, visit http://gerrit.ovirt.org/30059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icced7dda43fee83aa904a068cff48b1fd3da4b76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
