Mike Kolesnik has posted comments on this change. Change subject: core: macPool per DC, db changes ......................................................................
Patch Set 37: Code-Review-1 (2 comments) A few small comments, nothing serious. http://gerrit.ovirt.org/#/c/26795/37/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java: Line 6: Line 7: import org.hibernate.validator.constraints.NotEmpty; Line 8: import org.ovirt.engine.core.compat.Guid; Line 9: Line 10: public class MacPool extends IVdcQueryable implements BusinessEntity<Guid>, Serializable{ There's no need to specify Serializable explicitly. Also you should have a space before { Also you're missing a serialVersionUID (or a @SupressWarnings for this) Line 11: private Guid id; Line 12: Line 13: private String name; Line 14: http://gerrit.ovirt.org/#/c/26795/37/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacRange.java: Line 5: import javax.validation.constraints.NotNull; Line 6: Line 7: import org.ovirt.engine.core.compat.Guid; Line 8: Line 9: public class MacRange implements Serializable{ You should have a space before { Also you're missing a serialVersionUID (or a @SupressWarnings for this) Line 10: private Guid macPoolId; Line 11: Line 12: @NotNull Line 13: private String macFrom; -- To view, visit http://gerrit.ovirt.org/26795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
