Alon Bar-Lev has posted comments on this change.

Change subject: core: [WIP] [NON AS7.1.1] custom jboss login plugin using digest
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/29693/4/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/jboss_auth_plugin/OvirtAuthPlugIn.java
File 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/jboss_auth_plugin/OvirtAuthPlugIn.java:

Line 34:         private OvirtIdentity(final String userName) {
Line 35:             this.userName = userName;
Line 36:             this.credential = new ValidatePasswordCredential() {
Line 37:                 @Override public boolean validatePassword(char[] 
password) {
Line 38:                     LoginUserParameters parameters = new 
LoginUserParameters("", userName, new String(password));
you must specify profile name, better we enforce last @xxx as profile name, you 
can split it and feed us.
Line 39:                     parameters.setIsAdmin(true);
Line 40:                     return 
backendLocal.login(parameters).getSucceeded();
Line 41:                 }
Line 42:             };


-- 
To view, visit http://gerrit.ovirt.org/29693
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e504c9b429f7fe02d42b0170e6e3a08b801efae
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to