Gilad Chaplik has posted comments on this change.

Change subject: common: Introduce profiles package & Disk Profile
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.ovirt.org/#/c/27098/18/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java:

Line 29:     private ProfileType profileType;
Line 30: 
Line 31:     @SuppressWarnings("unused")
Line 32:     private ProfileBase() {
Line 33:     }
> why do you need this ctor?
gwt
Line 34: 
Line 35:     public ProfileBase(ProfileType profileType) {
Line 36:         this.setProfileType(profileType);
Line 37:     }


-- 
To view, visit http://gerrit.ovirt.org/27098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a9af22277b50554531511002f19046c0051d8ff
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kobi Ianko <k...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to