mooli tayer has posted comments on this change. Change subject: aaa: sort domain names a-b ascending. ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29721/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java: Line 6: import org.ovirt.engine.core.aaa.AuthenticationProfile; Line 7: import org.ovirt.engine.core.aaa.AuthenticationProfileRepository; Line 8: import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; Line 9: Line 10: import static java.util.Collections.sort; > any reason not to use Collections.sort() ? Just noticed this myself. in this case Collections.sort() will be clearer. Line 11: Line 12: public class GetAAAProfileListQuery<P extends VdcQueryParametersBase> extends QueriesCommandBase<P> { Line 13: Line 14: public GetAAAProfileListQuery(P parameters) { -- To view, visit http://gerrit.ovirt.org/29721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d0a64c872f8d2a018be08587303b5358c3a18c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
