Moti Asayag has posted comments on this change. Change subject: engine: Validate network provider properties ......................................................................
Patch Set 11: (5 comments) http://gerrit.ovirt.org/#/c/29520/11/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/NetworkProviderValidatorTest.java: Line 29: } Line 30: Line 31: @Test Line 32: public void invalidProviderType() { Line 33: provider.setType(NON_NETWORK_PROVIDER_TYPE); > You should do this via the mocking api, otherwise this call is just being s Done Line 34: assertThat(validator.providerTypeValid(), failsWith(VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_TYPE_MISMATCH)); Line 35: } Line 36: Line 37: @Test Line 35: } Line 36: Line 37: @Test Line 38: public void networkMappingsProvidedByParameters() throws Exception { Line 39: assertThat(validator.networkMappingsProvided("mappings"), isValid()); > Since the mapping string has no meaning, consider using a random generated Done Line 40: } Line 41: Line 42: @Test Line 43: public void networkMappingsProvidedByProvider() throws Exception { Line 41: Line 42: @Test Line 43: public void networkMappingsProvidedByProvider() throws Exception { Line 44: mockProviderAdditionalProperties(); Line 45: when(getProviderAgentConfiguration().getNetworkMappings()).thenReturn("mappings"); > Same here Done Line 46: assertThat(validator.networkMappingsProvided(null), isValid()); Line 47: } Line 48: Line 49: @Test Line 74: failsWith(VdcBllMessages.ACTION_TYPE_FAILED_MISSING_MESSAGING_BROKER_PROPERTIES)); Line 75: } Line 76: Line 77: @Test Line 78: public void missingBrokerAddressForMessagingBrokerValidation() throws Exception { > Essentially this is the same as missingMessagingConfigurationForMessagingBr Done Line 79: mockMessagingBrokerAddress(null); Line 80: Line 81: assertThat(validator.messagingBrokerProvided(), Line 82: failsWith(VdcBllMessages.ACTION_TYPE_FAILED_MISSING_MESSAGING_BROKER_PROPERTIES)); http://gerrit.ovirt.org/#/c/29520/11/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/ProviderValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/ProviderValidatorTest.java: Line 59: assertThat(validator.nameAvailable(), failsWith(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED)); Line 60: } Line 61: Line 62: @SuppressWarnings("unchecked") Line 63: protected Provider<AdditionalProperties> createProvider(String name) { > Don't see how this change is necessary Done Line 64: Provider<AdditionalProperties> p = mock(Provider.class); Line 65: when(p.getName()).thenReturn(name); Line 66: return p; Line 67: } -- To view, visit http://gerrit.ovirt.org/29520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcdcddb9694426c1e656c9fa1e04dc7f37e8115c Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
