mooli tayer has posted comments on this change.

Change subject: aaa: remove AdminDomain definition and treat like any other 
profile.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/29774/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java:

Line 32:             names.add(AuthzUtils.getName(extension));
Line 33:         }
Line 34:         if (getParameters().getFilterInternalDomain()) {
Line 35:             names.remove(INTERNAL);
Line 36:         }
> Indeed.
Done
Line 37:         sort(names);
Line 38: 
Line 39:         // Return the sorted list:
Line 40:         getQueryReturnValue().setReturnValue(names);


http://gerrit.ovirt.org/#/c/29774/1/packaging/dbscripts/upgrade/03_05_0760_remove_admin_domain_config_entry.sql
File 
packaging/dbscripts/upgrade/03_05_0760_remove_admin_domain_config_entry.sql:

Line 1: SELECT fn_db_delete_config_value_all_versions('AdminDomain');
> indeed.
done


-- 
To view, visit http://gerrit.ovirt.org/29774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I375df1489ed59d98a7be0e3d629b662a0d764d10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to