Arik Hadas has posted comments on this change. Change subject: core: Introduce NullSafeComparator ......................................................................
Patch Set 1: this method already exists in apache-commons-lang [1], can we move your implementation to ui-specific package so it won't be accessible in the backend? [http://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/ObjectUtils.html#compare%28T,%20T%29] -- To view, visit http://gerrit.ovirt.org/28947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc7d67927d646bf9d1f5e6f0736dbf1d15c7dd71 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches