Lior Vernia has posted comments on this change. Change subject: webadmin: Implement sorting for RxTxRateColumn ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28757/8/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/RxTxRateRenderer.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/RxTxRateRenderer.java: Line 8: public class RxTxRateRenderer extends AbstractRenderer<Double[]> { Line 9: Line 10: public static final String NO_VALUE = "[N/A]"; //$NON-NLS-1$ Line 11: public static final String ZERO_VALUE = "0"; //$NON-NLS-1$ Line 12: public static final String SMALL_VALUE = "< 1"; //$NON-NLS-1$ > Lior, you just gave the perfect answer why we should externalize. You're assuming that either of the bugs will surely be opened, which I think is a false assumption. * This option likely WON'T happen, because normal integer values will be displayed in Western digits (default character codes, not special characters). * This option likely WILL happen, because if you're a translator and are asked to translate a "0" string, you'll translate it. Which in this case would be wrong. Line 13: Line 14: @Override Line 15: public String render(Double[] values) { Line 16: if (values.length != 2 || values[0] == null || values[1] == null) { -- To view, visit http://gerrit.ovirt.org/28757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0a9b91350e774639a7879e26456f6e8cc15ba3d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
