Arik Hadas has posted comments on this change.

Change subject: core: infrastructure for VmDevices in next run VM snapshot
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/29384/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java:

Line 1098:         return deviceEnabled == vmDevices.isEmpty();
Line 1099:     }
Line 1100: 
Line 1101:     public static boolean vmDeviceChanged(Guid vmId, 
VmDeviceGeneralType deviceType, boolean deviceEnabled) {
Line 1102:         return vmDeviceChanged(vmId, null, deviceEnabled);
s/vmId, null, deviceEnabled/vmId, deviceType, null, deviceEnabled
Line 1103:     }
Line 1104: 
Line 1105:     /**
Line 1106:      * Returns a map (device ID to VmDevice) of devices that are 
relevant for next run by examining


-- 
To view, visit http://gerrit.ovirt.org/29384
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7add4e7e09fe8d6d1f93f0d2b96795d838efa2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to