Alon Bar-Lev has uploaded a new change for review.
Change subject: webadmin: aaa: fix group list comma construction
......................................................................
webadmin: aaa: fix group list comma construction
actually, the counter should have been incremented.
but there is no reason to use extra variable.
Topic: AAA
Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/29950/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
index 5161202..60431f5 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java
@@ -60,12 +60,11 @@
@Override
public String getValue(DbUser object) {
StringBuilder builder = new StringBuilder();
- int counter = 0;
for (String name : object.getGroupNames()) {
- builder.append(name);
- if (counter < object.getGroupNames().size() - 1) {
+ if (builder.length() > 0) {
builder.append(","); //$NON-NLS-1$
}
+ builder.append(name);
}
return builder.toString();
}
--
To view, visit http://gerrit.ovirt.org/29950
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8b5bd60cfdcea2f5593364ed4c9a36ff4f3550d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
