Allon Mureinik has posted comments on this change. Change subject: core: Add space validation when creating snapshot ......................................................................
Patch Set 6: (1 comment) Much better! There's still a potential bug in the test (due to static declaration - see inline), but it's an easy fix. Please perform it and verify so this patch can be merged. http://gerrit.ovirt.org/#/c/29258/6/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java: Line 46: Line 47: private Guid spId; Line 48: Line 49: private static Guid sdId1; Line 50: private static Guid sdId2; Making these static is a code smell - it prevents sophisticated runners from running the test cases in parallel (note that they're still initialized per test, in the @Before method. Please return them to be instance variables, and make generateDisksList an instance method too. Line 51: Line 52: private StorageDomain domain1; Line 53: private StorageDomain domain2; Line 54: -- To view, visit http://gerrit.ovirt.org/29258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a5b5df695d30a34fbdef31da2320b322e27466b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
