Alona Kaplan has posted comments on this change. Change subject: webadmin: SetupNetwork>edit network(with pencil)>can't edit network ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29735/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnumRadioEditor.java: Line 258: Line 259: @Override Line 260: public HandlerRegistration addValueChangeHandler(final ValueChangeHandler<E> handler) { Line 261: // don't add to peer, since its changed value is the entire item list Line 262: return handlerManager.addHandler(ValueChangeEvent.getType(), handler); > I don't understand that peer comment. Could you elaborate why you can't cal this.addHandler() doesn't exist. If you mean asWidget().addHandler(), asWidget() returns the peer. As I said in the comment about the peer- the peer is EnumRadioCellTable, we don't want to listen to value changes of the peer as the peer's value is the whole list. We just want to listen to 'valueChange' which is fired by selectionModel->onSelectionChanged(). Line 263: } Line 264: Line 265: @Override Line 266: public TakesValueWithChangeHandlersEditor<E> asEditor() { -- To view, visit http://gerrit.ovirt.org/29735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83c330b8340ba1cf6b2382877b23d07c25fc1afb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
