Allon Mureinik has posted comments on this change. Change subject: core: Add VdcQueryType test ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29794/2/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueryExistenceTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueryExistenceTest.java: Line 11: public class QueryExistenceTest { Line 12: Line 13: @Test Line 14: public void testQueryClassExistence() { Line 15: List<VdcQueryType> missingQueries = new ArrayList<>(); Nit: A LinkedList would be more suited for this kind of usage. Line 16: for (VdcQueryType vqt : VdcQueryType.values()) { Line 17: if (vqt != VdcQueryType.Unknown) { Line 18: if (CommandsFactory.getQueryClass(vqt.name()) == null) { Line 19: missingQueries.add(vqt); -- To view, visit http://gerrit.ovirt.org/29794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4cf3e10f2dfd2b132283d2408c1079e37a9789df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
