Vojtech Szocs has posted comments on this change. Change subject: core: enable ConfigValues injection ......................................................................
Patch Set 7: Code-Review+1 Nice draft patch, just a few comments: * BllCDIAdapter.produceConfigValue - currently works only for ConfigValues members typed as Integer via @TypeConverterAttribute(Integer.class) - how will this look like when we want to support other types like String, Boolean, etc.? * stuff under frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/ - is this really necessary? Sources placed here are meant to override their default (backend Java) implementations for use with GWT, but types like Config & @ConfigValue should not be used in frontend code, and therefore these overrides should not be necessary (?) -- To view, visit http://gerrit.ovirt.org/29539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c4d5f6239d5f4fd7737f9637d1a6e999020b1b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
