Maor Lipchuk has posted comments on this change. Change subject: core: add tests for AddExistingFileStorageDomainCommand ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29783/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java: Line 77: return concreteCheckExistingStorageDomain(domainFromIrs); Line 78: } Line 79: Line 80: protected List<Guid> executeHSMGetStorageDomainsList(HSMGetStorageDomainsListVDSCommandParameters parameters) { Line 81: return (ArrayList<Guid>) runVdsCommand(VDSCommandType.HSMGetStorageDomainsList, parameters).getReturnValue(); can it be cast to List? Line 82: } Line 83: Line 84: protected Pair<StorageDomainStatic, Guid> executeHSMGetStorageDomainInfo(HSMGetStorageDomainInfoVDSCommandParameters parameters) { Line 85: return (Pair<StorageDomainStatic, Guid>) runVdsCommand(VDSCommandType.HSMGetStorageDomainInfo, parameters).getReturnValue(); Line 103: } Line 104: return returnValue; Line 105: } Line 106: Line 107: protected DbFacade getDbFacade() { > getDbFacade is already in StorageHandlingCommandBase could be removed Line 108: return DbFacade.getInstance(); Line 109: } -- To view, visit http://gerrit.ovirt.org/29783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae99fc564942fe8ff92f3e7e133d5c6c4d4bba49 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
