Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fixed a small mess in host network popup ......................................................................
webadmin: Fixed a small mess in host network popup Probably due to a lapse in concentration at the time, the changeability of network custom properties depended upon the ability to change boot protocol, where it should have depended solely on whether the network was marked to by synchronized (it should still work when the boot protocol is set to "None", which disables the boot protocol fields). Also, while fixing this I noticed that host QoS wasn't disabled for the same cases, when it actually should be. Change-Id: I486cc099cf7698f0d685c398c00215b0bab2f3fa Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java 5 files changed, 36 insertions(+), 11 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/29229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486cc099cf7698f0d685c398c00215b0bab2f3fa Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
