Moti Asayag has posted comments on this change. Change subject: <core | restapi | tools | history | engine | userportal | webadmin>: ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29846/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java: Line 55: return getParameters().getMacPool(); Line 56: } Line 57: Line 58: @Override Line 59: protected void executeCommand() { if you'll take a look at AddNetworkCommand.executeCommand() you'll notice NetworkHelper.addPermissionsOnNetwork(getCurrentUser().getId(), getNetwork().getId()); it grants an explicit role of NETWORK_ADMIN to the user which created the network i think we should have the same behavior to give MAC_POOL_ADMIN role to the user which performed that action on AddMacPoolCommand Line 60: getMacPoolEntity().setId(Guid.newGuid()); Line 61: getMacPoolDao().save(getMacPoolEntity()); Line 62: Line 63: MacPoolPerDcSingleton.getInstance().createPool(getMacPoolEntity()); -- To view, visit http://gerrit.ovirt.org/29846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f5d080b6628f86ab2ff88f8e2dfaab21d367c7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
