Yedidyah Bar David has uploaded a new change for review. Change subject: packaging: setup: test only config file db password ......................................................................
packaging: setup: test only config file db password Testing also env breaks unattended clean setup. Bug-Url: https://bugzilla.redhat.com/1094016 Bug-Url: https://bugzilla.redhat.com/1100281 Change-Id: I7a721ce3322bab5ea972e43bd8155beb9b447f30 Signed-off-by: Yedidyah Bar David <d...@redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-dwh refs/changes/56/29856/1 diff --git a/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py b/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py index c4d9965..c9f219d 100644 --- a/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py +++ b/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py @@ -112,10 +112,7 @@ odwhcons.FileLocations.OVIRT_ENGINE_DWHD_SERVICE_CONFIG_DEFAULTS, odwhcons.FileLocations.OVIRT_ENGINE_DWHD_SERVICE_CONFIG, ]) - if ( - config.get('DWH_DB_PASSWORD') or - self.environment.get(odwhcons.DBEnv.PASSWORD) - ): + if config.get('DWH_DB_PASSWORD'): try: dbenv = {} for e, k in ( -- To view, visit http://gerrit.ovirt.org/29856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a721ce3322bab5ea972e43bd8155beb9b447f30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.4 Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches