Michael Pasternak has posted comments on this change. Change subject: cli: No regular expression for IP, UUID or number ......................................................................
Patch Set 1: that's correct, it off by default (uuid and ip converted to strings now), but as cli command has support for accepting argument of certain type only, you can cast args to the actual type at any time, and use this feature. in future (forced by business logic, etc.) you may decide that command X accepts identifiers of UUID only, but after this change you won't have such ability, juan, i know it's easy to give advices, but please consider extending text processing capabilities rather than removing them, (sorry for not giving a hand on this, apparently being contributor is much harder than i thought) -- To view, visit http://gerrit.ovirt.org/29722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If670144751fdb9564380a12fb73596ecbaa47ee9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Ilia Meerovich <imeer...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
