Lior Vernia has posted comments on this change. Change subject: webadmin: Sort NIC column in Network/Hosts subtab ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28756/7/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java: Line 235: String name1 = (o1.getFirst() == null) ? null : o1.getFirst().getName(); Line 236: String name2 = (o2.getFirst() == null) ? null : o2.getFirst().getName(); Line 237: return lexoNumeric.compare(name1, name2); Line 238: } Line 239: }); > 1) This isn't likely to be re-used by anyone else, it compares PairQueryabl 2) NameableComparator won't work here because the VdsNetworkInterface that's part of the pair can be null. Also, NameableComparator compares strings using their default sort order, so not as good as LexoNumeric (maybe should be changed to use LexoNumeric anyway). Line 240: speedColumn.makeSortable(); Line 241: } Line 242: } -- To view, visit http://gerrit.ovirt.org/28756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie52ec4faafbb06a6cd62b988edc11d32db3bb765 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
