Tal Nisan has posted comments on this change.

Change subject: webadmin: call GetConfigurationValue with version
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Wouldn't it be cleaner to make it that when no version is defined for the 
query, the value is fetched with the default version? It will save the changes 
to all the places which doesn't define a version explicitly

--
To view, visit http://gerrit.ovirt.org/5604
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I191edbde4529b97d6ebca2c03cf71f3a8058419e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to