Oved Ourfali has posted comments on this change. Change subject: engine, webadmin: Webadmin needs to be able to read reports.xml via GET from remote reports app ......................................................................
Patch Set 7: (1 comment) minor comment + a general question here: Will this code run even if the reports server isn't even configured? I'll E-mail Alona to make sure she reviews (I guess won't happen today, but tomorrow morning). Oved http://gerrit.ovirt.org/#/c/29723/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java: Line 134: Line 135: @Override Line 136: public void onResponseReceived(Request request, Response response) { Line 137: if (response.getStatusCode() == Response.SC_OK Line 138: && response.getText().trim().equals(REPORTS_WEBAPP_DEPLOYED_MSG)) { you no longer need the second part in this if, right? Line 139: reportsWebappDeployed = true; Line 140: parseReportsXML(); Line 141: } Line 142: } -- To view, visit http://gerrit.ovirt.org/29723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
