Shahar Havivi has uploaded a new change for review. Change subject: engine: Set boot order to more then one CDROM if selected ......................................................................
engine: Set boot order to more then one CDROM if selected When dealing with more then one CDROM we set only the first in list if user select boot order from CDROM, which can cause a problem if the first CDROM is payload or cloud-init which are not bootable. When setting all CDROM to be bootable qemu will try to boot from one of them. Change-Id: I1f0b8b6a8346dd71b716df8d90f852de550bae97 Bug-Url: https://bugzilla.redhat.com/1064927 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/29773/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java index f82763e..eeb391f 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java @@ -208,11 +208,8 @@ */ private static int setCDBootOrder(List<VmDevice> devices, int bootOrder) { for (VmDevice device : devices) { - if (isCD(device)) { - if (device.getIsPlugged()) { - device.setBootOrder(++bootOrder); - } - break; // only one CD is currently supported. + if (isCD(device) && device.getIsPlugged()) { + device.setBootOrder(++bootOrder); } } return bootOrder; -- To view, visit http://gerrit.ovirt.org/29773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1f0b8b6a8346dd71b716df8d90f852de550bae97 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
