Piotr Kliczewski has posted comments on this change. Change subject: core: VdsManger - rename fields to fit convention ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/27378/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 153: } Line 154: Line 155: private void InitVdsBroker() { Line 156: log.infoFormat("Initialize vdsBroker ({0},{1})", vds.getHostName(), vds.getPort()); Line 157: vdsProxy = new VdsServerWrapper(vds.getHostName(), vds.getPort()); Why TransportFactory was removed? Line 158: } Line 159: Line 160: public void updateVmDynamic(VmDynamic vmDynamic) { Line 161: DbFacade.getInstance().getVmDynamicDao().update(vmDynamic); Line 412: calculateNextMaintenanceAttemptTime(); Line 413: } Line 414: vds.setPreviousStatus(vds.getStatus()); Line 415: if (this.vds != null) { Line 416: this.vds.setPreviousStatus(vds.getStatus()); Above we are not using this. I think we should be consistent across the class. Line 417: } Line 418: } Line 419: // update to new status Line 420: vds.setStatus(status); -- To view, visit http://gerrit.ovirt.org/27378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90e26c1a2db4d51f5bd13cf39a59593579fa7648 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
