Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: show advanced options on validation error ......................................................................
Patch Set 2: Code-Review+1 (1 comment) One minor thing, other than that I think we should be able to do this for 3.5, then merge it with the other patch for 3.6 http://gerrit.ovirt.org/#/c/28979/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 2744: setIsHostTabValid(true); Line 2745: setIsAllocationTabValid(true); Line 2746: setIsBootSequenceTabValid(true); Line 2747: setRngTabValid(true); Line 2748: setIsCustomPropertiesTabValid(true); maybe reset the isValid entity here as well, that way you don't have to make a separate call in a lot of places? Line 2749: } Line 2750: Line 2751: private class RngDevValidation implements IValidation { Line 2752: -- To view, visit http://gerrit.ovirt.org/28979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b419b560fe1e0bc0c8114d2a34f0bc930756aa0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
