Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: fixing hostname validation ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29512/2//COMMIT_MSG Commit Message: Line 7: packaging: setup: fixing hostname validation Line 8: Line 9: engine-setup validates hostnames to avoid strange behaviours; Line 10: it's done via a regular expression. Line 11: Fixing it to avoif the match of '_' which is avoid Line 12: not a valid character in a hostname according to RFC 952 Line 13: An invalid hostname can cause strange behaviour interacting Line 14: with other components. Line 15: -- To view, visit http://gerrit.ovirt.org/29512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5c56bc5642bfb18629c1a0ad780e8a0e58a3531 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
