Alona Kaplan has posted comments on this change. Change subject: webadmin: Network dialog- default/custom mtu as radio buttons ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/28099/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java: Line 131: mtuSelector.getSelectedItemChangedEvent().addListener(new IEventListener() { Line 132: Line 133: @Override Line 134: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 135: getMtu().setIsChangable(isCustomMtu()); > I lied, here's another comment. Maybe it's better to call updateMtuSelector 1. If mtuOverride isn't supported the mtu value is default for sure. 2. I can't think about a race that can cause a bug in this case. But just to be on the safe side, I"ll do the change. Line 136: } Line 137: }); Line 138: Line 139: setMtu(new EntityModel<Integer>()); -- To view, visit http://gerrit.ovirt.org/28099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f813fd292b56407c97ae69c1580061bbc0eef04 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
