Yaniv Dary has posted comments on this change. Change subject: engine, webadmin: Webadmin needs to be able to read reports.xml via GET from remote reports app ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29723/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ReportInit.java: Line 134: @Override Line 135: public void onResponseReceived(Request request, Response response) { Line 136: try { Line 137: if (response.getStatusCode() == Response.SC_OK) { Line 138: if (response.getText().trim().equals(REPORTS_WEBAPP_NOT_DEPLOYED_MSG)) { > And here you'll check the return status, and not parse the response text. You can use Status servlet to check this. Line 139: scheduleParseReportsXML(); Line 140: } Line 141: else if (ReportParser.getInstance().parseReport(response.getText())) { Line 142: resourceMap = ReportParser.getInstance().getResourceMap(); -- To view, visit http://gerrit.ovirt.org/29723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76db7ab889f21de083bb3c8276e8abb77b68fdb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
