Alon Bar-Lev has posted comments on this change.

Change subject: extmgr: Engine should start even if there is a wrong 
configuration of extension
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/29728/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java:

Line 81:                         if (file.getName().endsWith(".properties")) {
Line 82:                             try {
Line 83:                                 load(file);
Line 84:                             } catch (Exception ex) {
Line 85:                                 log.error("Could not load extension 
based on configuration file '{}'. Please check the configuration file is 
valid.", file.getAbsolutePath());
please display ex.getMessage(), please dump debug stack trace
Line 86:                             }
Line 87:                         }
Line 88:                     }
Line 89:                 }


-- 
To view, visit http://gerrit.ovirt.org/29728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac6b522eb8d5fc1f3993780e6c1f09f7e5046757
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to