Alexander Wels has posted comments on this change. Change subject: webadmin: Reason does not get updated when trying to shut down a VM which is Powering up of Shutting Down ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29668/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 1678: for (Object item : getSelectedItems()) Line 1679: { Line 1680: VM vm = (VM) item; Line 1681: items.add(vm.getName()); Line 1682: if (stoppingSingleVM && reasonVisible && VMStatus.PoweringDown.equals(vm.getStatus()) ) { Why is there a space between )) and )? Also maybe a comment about exactly the reason this is here, After reading it a few times it made sense, but my initial reaction was, what is this? That usually means there needs to be some comment about what this does. Line 1683: model.getReason().setEntity(vm.getStopReason()); Line 1684: } Line 1685: } Line 1686: model.setItems(items); -- To view, visit http://gerrit.ovirt.org/29668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b10ed39563385cf99a366a32eebcc0c5ce08e72 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
