Ravi Nori has posted comments on this change. Change subject: engine : Save CommandContext in ContextCache ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/29501/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 33: Line 34: private static final ExecutorService executor = Executors.newFixedThreadPool(Config.<Integer>getValue(ConfigValues.CommandCoordinatorThreadPoolSize)); Line 35: private static final Log log = LogFactory.getLog(CommandExecutor.class); Line 36: Line 37: private final CommandCoordinatorImpl coco; > Why Impl? We are using a package private method saveCommandContext which is not exposed in the public CoCo interface. So using impl here. Line 38: private final Map<Guid, CommandCallBack> cmdCallBackMap = new ConcurrentHashMap<>(); Line 39: private Object LOCK = new Object(); Line 40: private volatile boolean cmdExecutorInitialized; Line 41: -- To view, visit http://gerrit.ovirt.org/29501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b968f787b60f83cf96411a97dd6380421f724b9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
