Juan Hernandez has posted comments on this change. Change subject: restapi: overgrown switch removal ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Please verify. http://gerrit.ovirt.org/#/c/29673/1/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java: Line 40: @Mapping(from = ActionGroup.class, to = PermitType.class) Line 41: public static PermitType map(ActionGroup entity, PermitType template) { Line 42: try { Line 43: return PermitType.valueOf(entity); Line 44: } catch (IllegalArgumentException e) { I think we should send a message to the log with this exception, otherwise it will be silently ignored, and the nice message that you prepared in the "valueOf" method will be useless. Line 45: return null; Line 46: } Line 47: } Line 48: -- To view, visit http://gerrit.ovirt.org/29673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b877d7123210374470b8c97a937c387921e4521 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
